PR[9] (combine PR-1-PR-8) feat: combine weeks 1-9 implementations into single branch#245
Draft
San1357 wants to merge 25 commits intotheochem:masterfrom
Draft
PR[9] (combine PR-1-PR-8) feat: combine weeks 1-9 implementations into single branch#245San1357 wants to merge 25 commits intotheochem:masterfrom
San1357 wants to merge 25 commits intotheochem:masterfrom
Conversation
Author
Summary (Final Completion Of WOC #221 )
Boys Functions (Week 1)
OS+HGP Two-Electron Integrals (Weeks 2–5)
Schwarz Screening (Week 6)
PySCF Validation + Tutorial (Week 7)
libcint Tolerance Fix (Week 8)
Request :This PR closes #221, #216, #208 and is ready for final review and merge. |
msricher
reviewed
Mar 11, 2026
Collaborator
msricher
left a comment
There was a problem hiding this comment.
Thanks for combining it all. Let's await a final review.
Comment on lines
+19
to
+24
| try: | ||
| from pyscf import gto | ||
| HAS_PYSCF = True | ||
| except ImportError: | ||
| HAS_PYSCF = False | ||
|
|
Collaborator
There was a problem hiding this comment.
I'm not sure this and the stuff at the bottom is necessary, it's not standard and I wouldn't expect it if I triggered it myself. I would simply dd PySCF to the [test] dependencies in the pyproject.toml file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
feat/boys-functionsfeat/electron-repulsion-improvedfeat/VRR-two-electron-integralfeat/ETR-contractionfeat/HRR-complete-pipelinefeat/schwarz-screeningfeat/pyscf-tests-tutorialfeat/libcint-tolerance-fixTest Results
Related PRs
This PR closes #221, #216, #208 and is ready for final review and merge.
Please let me know (@PaulWAyers , @marco-2023 , @msricher ) if any further changes or refinements are needed. Thank you!