[PR-4] feat: implement HRR (Eq. 67) and complete OS+HGP two-electron integral pipeline#238
Draft
San1357 wants to merge 9 commits intotheochem:masterfrom
Draft
[PR-4] feat: implement HRR (Eq. 67) and complete OS+HGP two-electron integral pipeline#238San1357 wants to merge 9 commits intotheochem:masterfrom
San1357 wants to merge 9 commits intotheochem:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_horizontal_recursion_relation()— HRR (Eq. 67), transfers angular momentum to center B and Dcompute_two_electron_integrals_os_hgp()— complete OS+HGP pipeline entry pointWhat Changed
gbasis/integrals/_two_elec_int_improved.pytests/test_two_elec_int_improved.pyMathematical Reference
The Horizontal Recursion Relation (Eq. 67) is:
where angular momentum is transferred from center A to center B (and similarly C to D).
How To Test
Proof That It Works
Tests (16 passed)
Check coverage
Black: Clean & Ruff: Clean
Existing tests: Not broken
307 passed, 279 skipped, 1 xfailed, 4 warnings in 67.52s (0:01:07)
First Checklist
Scope of this PR
_vertical_recursion_relation(VRR)_electron_transfer_recursion(ETR)_optimized_contractionwith per-center vectorized norm computation_horizontal_recursion_relation(HRR)compute_two_electron_integrals_os_hgp(full pipeline)Second Checklist
Type of Changes