[PR1] feat: add Boys function for 2 electron and validation tests#231
[PR1] feat: add Boys function for 2 electron and validation tests#231San1357 wants to merge 6 commits intotheochem:masterfrom
Conversation
msricher
left a comment
There was a problem hiding this comment.
This looks good to me so far, clean code and good tests. In .gitignore, qc-dev-env/ is just your local Python virtualenv? If so, then don't include it here; ignores specific to you or your machine go in .git/info/exclude.
|
@msricher Thanks for the Positive feedback & review. Yes, qc-dev-env is my local Python virtualenv. I've moved it from .gitignore to .git/info/exclude in the latest commit. |
|
@msricher I've also tried to optimized
|
msricher
left a comment
There was a problem hiding this comment.
@marco-2023 can you also review it? I think it's ready for merge.
|
Hi @msricher , @marco-2023 @PaulWAyers What's new in this updateThe initial PR set up the core Boys function ( 1.Downward Recursion — 2. Range-Separated Potentials — 3. High-Precision Reference — TestsAdded |
Summary
hyp1f1(Kummer confluent hypergeometric function)boys_function_standardfor single-order evaluationboys_function_all_ordersfor computing F_m(T) for m = 0 to m_maxget_boys_functionfactory for selecting potential typeWhat Changed
gbasis/integrals/boys_functions.pytests/test_boys_functions.py.gitignoreMathematical Reference
The Boys function is defined as:
Computed using the relation with Kummer's confluent hypergeometric function (Helgaker eq. 9.8.39):
How To Test
Proof That It Works
Tests (15 passed)
Black: Clean
Ruff: Clean
Existing tests: Not broken
306 passed, 279 skipped, 1 xfailed, 4 warnings in 66.88s
Checklist
Scope of this PR
Checklist
Type of Changes