Skip to content

refactor(deps): migrate d3 from v5.7.0 to v7.9.0 #7067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
digital-wizard48 wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −5
Open

refactor(deps): migrate d3 from v5.7.0 to v7.9.0 #7067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"@bazel/jasmine": "5.7.0",
"@bazel/terser": "5.7.0",
"@bazel/typescript": "5.7.0",
"@types/d3": "5.7.2",
"@types/d3": "7.4.0",
"@types/jasmine": "^3.8.2",
"@types/lodash": "^4.14.172",
"@types/marked": "^2.0.4",
Expand Down Expand Up @@ -117,7 +117,7 @@
"@tensorflow/tfjs-backend-webgl": "3.4.0",
"@tensorflow/tfjs-core": "3.4.0",
"@vaadin/vaadin-grid": "^20.0.2",
"d3": "5.7.0",
"d3": "7.9.0",
"dagre": "^0.8.5",
"lodash": "^4.17.19",
"marked": "^4.0.10",
Expand Down
5 changes: 2 additions & 3 deletions tensorboard/components/tf_color_scale/colorScale.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
==============================================================================*/
import * as d3 from 'd3';
import {BaseStore} from '../tf_backend/baseStore';
import {experimentsStore} from '../tf_backend/experimentsStore';
import {runsStore} from '../tf_backend/runsStore';
Expand All @@ -25,7 +24,7 @@ import {standard} from './palettes';
// ccs.getColor("train");
// ccs.getColor("test1");
export class ColorScale {
private identifiers = d3.map();
private identifiers = new Map<string, string>();
/**
* Creates a color scale with optional custom palette.
* @param {Array<string>} palette The color palette to use, as an
Expand All @@ -38,7 +37,7 @@ export class ColorScale {
* domain for your scale.
*/
public setDomain(strings: string[]): this {
this.identifiers = d3.map();
this.identifiers = new Map<string, string>();
strings.forEach((s, i) => {
this.identifiers.set(s, this.palette[i % this.palette.length]);
});
Expand Down