refactor(deps): migrate d3 from v5.7.0 to v7.9.0#7067
Open
digital-wizard48 wants to merge 1 commit intotensorflow:masterfrom
Open
refactor(deps): migrate d3 from v5.7.0 to v7.9.0#7067digital-wizard48 wants to merge 1 commit intotensorflow:masterfrom
digital-wizard48 wants to merge 1 commit intotensorflow:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Version bumps
d3from5.7.0to7.9.0inpackage.json@types/d3from5.7.2to7.4.0inpackage.jsonto match the new d3 major versionBreaking API changes addressed
d3.map()removed (d3 v6+)In d3 v6, the
d3.map(),d3.set(),d3.keys(),d3.values(), andd3.entries()collection helpers were removed in favor of native JavaScriptMap,Set,Object.keys(),Object.values(), andObject.entries().tensorboard/components/tf_color_scale/colorScale.ts: Replacedd3.map()usages with nativenew Map<string, string>(). The d3 import was also removed from this file since it is no longer needed after this migration.Other d3 v6/v7 breaking changes (not present in provided files)
d3.eventwas removed; event handlers now receive the event as their first argumentd3.mouse,d3.touch,d3.touches,d3.clientPointwere removed in favor ofd3.pointerselection.oncallbacks now receive(event, datum)instead of(datum, index, groups)withd3.eventd3.histogramwas renamed tod3.bind3.ascending/d3.descendingcomparator argument order changedThese changes may affect other files in the codebase not included in this review.
This PR was auto-generated by Gittensor upgrade bot using Claude AI