-
Notifications
You must be signed in to change notification settings - Fork 0
Program hood and add DependencyOrderedExecutor to schedule periodic actions #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This is not how you implement Kahn's. Your implementation is For the incoming part, like I said, don't actually remove edges. Simply keep a count |
…1, reducing max error from >40in to <2in
|
I've reimplemented it as you described. Thanks for letting me know. |
…n validate hood angles
…n tasks out of RobotContainer
godmar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just made a brief run through, will look at it more closely later.
|
I have fixes for all comments done but my wifi is out so I cannot push changes until it comes back. |
…yer to use builder architecture, split up shot calculation methods
|
@godmar would you mind looking over some of the architecture changes I made and seeing if you find them to be cleaner than before? |
I'm looking at it. Who is going to resolve all these conversation above? I understood that it would be your responsibility? |
godmar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check the math in controlToGoalHeading
|
Side note: with the new test mode manager where each subsystem has its own, the (Implemented here in Theta's branch.) |
I have to add field locations and then fix the turret math. Those will be my next 2 tasks. |
…al value causing homing switch to always be pressed on code startup








Adds:
Closes #33