Fixes the bug of unexpected stall cycles during prologue.#285
Merged
Conversation
tancheng
reviewed
Apr 19, 2026
tancheng
reviewed
Apr 21, 2026
tancheng
reviewed
Apr 23, 2026
tancheng
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Jackcuii #281 (comment) should have been fixed in this PR, can you check whether it works on your side?
@tancheng
Replacing the operation with OPT_NAH during the prologueis now implemented in the ctrl mem. I have also further restricted some control signals in the crossbar to toggle only after the prologue, and added a test to confirm that the unexpected stall cycles during the prologue are fixed. Please review.