Add support for inline completions (WIP)#2552
Draft
jwortmann wants to merge 8 commits intosublimelsp:mainfrom
Draft
Add support for inline completions (WIP)#2552jwortmann wants to merge 8 commits intosublimelsp:mainfrom
jwortmann wants to merge 8 commits intosublimelsp:mainfrom
Conversation
✅ Deploy Preview for sublime-lsp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
e9e738d to
9c4fb88
Compare
9c4fb88 to
2d6aed5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
| listener.inline_completion.position = position | ||
| listener.inline_completion.render_async(0) | ||
|
|
||
| # filter_text = item.get('filterText', insert_text) # ignored for now |
Co-authored-by: Предраг Николић <idmpepe@gmail.com>
f806ca0 to
90081a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimental / work in progress
Implementation details are open for discussion and it would be nice to gather some opinions how inline completions should work.
It can be tested with Tabby; for setup see #2520 or the docs description which is added in this PR. Tabby requires a compatible GPU.
For this PR I hijacked the Alt + Enter key binding which is currently used for "insert completion with opposite insert mode", because there aren't really any good key bindings left (everything with Ctrl or Shift is already taken in the ST default key bindings). This was mostly for testing and is up for discussion I guess.
I haven't really looked at the implementations in e.g. LSP-copilot yet. Perhaps there are some improvements that we can adopt.