Conversation
| The JSON language server has the following dependencies on the client's capabilities: | ||
|
|
||
| - Code completion requires that the client capability has *snippetSupport*. If not supported by the client, the server will not offer the completion capability. | ||
| - Inline suggestion requires that the client capability has *snippetSupport*. If not supported by the client, the server will not offer the completion capability. |
There was a problem hiding this comment.
When I first read inline suggestion, I first thought that the JSON ls implemented the inline completion LSP spec
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#textDocument_inlineCompletion
And that I can test
sublimelsp/LSP#2552
But it is kind of misleading. Because I the JSON language server doesn't support inline completion. (I need to verify this)
It seems like these updates in .md files in the remote repo were done by Copilot and were part of this PR
microsoft/vscode#272447
Note to self (because I am reviewing this PR on my phone) verify if the JSON language server supports inline Completion
There was a problem hiding this comment.
Even diff doesn't show any meaningful changes and if such feature would be added, it would have to be added here. So it's really some mistake
There was a problem hiding this comment.
Looks like vs code is updating the terminology from "code completion" to "inline completion" (I don't have access to the internal vs code board to gain more context for the change).
microsoft/vscode-docs#9000
There was a problem hiding this comment.
Hello @benibenj @bpasero, I am reaching out regarding microsoft/vscode#272447
Can you help me clear things up regarding the rename change from "code completion" to "inline completion"?
The LSP spec distinguishes between "code completion" (textDocument/completion) and "inline completion" (textDocument/inlineCompletion).
Renaming "code completion" to "inline completion" in the JSON server README seems misleading since that server doesn't implement the inlineCompletion capability. Is this terminology change intentional even for servers only supporting standard completions?
3 participants
includes changes from the json service: microsoft/vscode-json-languageservice@v5.6.1...v5.7.1