Skip to content

fix: extension Install button opens store listings, not GitHub docs #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stylessh merged 1 commit into from
Apr 13, 2026
Merged

fix: extension Install button opens store listings, not GitHub docs #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions apps/dashboard/src/lib/extension-store-url.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,24 @@
import { siteConfig } from "#/lib/site-config";
/** Canonical listing URLs (also used by `siteConfig` for SEO / consistency). */
export const CHROME_EXTENSION_STORE_URL =
"https://chromewebstore.google.com/detail/celjddfjncnnkgfgldobcahfiimlebll/" as const;

export const FIREFOX_EXTENSION_STORE_URL =
"https://addons.mozilla.org/en-US/firefox/addon/diffkit/" as const;
Copy link
Copy Markdown
Owner Author

@stylessh stylessh Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should change this


function isFirefoxFamilyUserAgent(ua: string): boolean {
// Desktop Firefox: "Firefox/123"; Firefox iOS: "FxiOS/123"; avoid relying on siteConfig.
return /(?:Firefox|FxiOS)\//i.test(ua);
}

/**
* Resolves the correct extension listing for the user's browser (Firefox AMO vs Chrome Web Store).
* Uses inline URLs so the install link never depends on a mis-resolved or stale `siteConfig` bundle.
*/
export function getExtensionStoreInstallUrl(): string {
if (typeof navigator === "undefined") {
return siteConfig.chromeExtensionStoreUrl;
}
const ua = navigator.userAgent;
if (/Firefox\//i.test(ua)) {
return siteConfig.firefoxExtensionStoreUrl;
return CHROME_EXTENSION_STORE_URL;
}
return siteConfig.chromeExtensionStoreUrl;
return isFirefoxFamilyUserAgent(navigator.userAgent)
? FIREFOX_EXTENSION_STORE_URL
: CHROME_EXTENSION_STORE_URL;
}
11 changes: 7 additions & 4 deletions apps/dashboard/src/lib/site-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
import {
CHROME_EXTENSION_STORE_URL,
FIREFOX_EXTENSION_STORE_URL,
} from "#/lib/extension-store-url";

type SiteConfig = {
name: string;
domain: string;
Expand All @@ -19,10 +24,8 @@ export const siteConfig: SiteConfig = {
name: "DiffKit",
domain: "diff-kit.com",
url: "https://diff-kit.com",
chromeExtensionStoreUrl:
"https://chromewebstore.google.com/detail/celjddfjncnnkgfgldobcahfiimlebll/",
firefoxExtensionStoreUrl:
"https://addons.mozilla.org/en-US/firefox/addon/diffkit/",
chromeExtensionStoreUrl: CHROME_EXTENSION_STORE_URL,
firefoxExtensionStoreUrl: FIREFOX_EXTENSION_STORE_URL,
githubRepositoryUrl: "https://github.com/stylessh/diffkit",
themeColor: "#00C943",
socialImagePath: "/logo512.png",
Expand Down
Loading