fix: extension Install button opens store listings, not GitHub docs#99
Merged
fix: extension Install button opens store listings, not GitHub docs#99
Conversation
- Define CHROME_EXTENSION_STORE_URL / FIREFOX_EXTENSION_STORE_URL in extension-store-url - getExtensionStoreInstallUrl reads those constants only (avoids stale README URLs) - siteConfig re-exports same constants; detect FxiOS for Firefox iOS
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
diffkit | a244555 | Apr 13 2026, 08:40 PM |
stylessh
commented
Apr 13, 2026
| "https://chromewebstore.google.com/detail/celjddfjncnnkgfgldobcahfiimlebll/" as const; | ||
|
|
||
| export const FIREFOX_EXTENSION_STORE_URL = | ||
| "https://addons.mozilla.org/en-US/firefox/addon/diffkit/" as const; |
stylessh
added a commit
that referenced
this pull request
Apr 18, 2026
…#99) - Define CHROME_EXTENSION_STORE_URL / FIREFOX_EXTENSION_STORE_URL in extension-store-url - getExtensionStoreInstallUrl reads those constants only (avoids stale README URLs) - siteConfig re-exports same constants; detect FxiOS for Firefox iOS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The extension install chip could send users to the GitHub README (docs) instead of Chrome Web Store / Firefox AMO.
Cause
getExtensionStoreInstallUrl()read store URLs fromsiteConfig, which could resolve incorrectly in some bundles/deploys.Fix
CHROME_EXTENSION_STORE_URLandFIREFOX_EXTENSION_STORE_URLinextension-store-url.tsand use them directly ingetExtensionStoreInstallUrl().site-config.tsimports the same constants so values stay single-source.FxiOS/(Firefox on iOS).