Skip to content

fix: align deny rule messages to use "must" instead of "should" #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: argocdcloud
Choose a base branch
from
Draft

fix: align deny rule messages to use "must" instead of "should" #36

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b18cd3
Initial plan
Copilot Mar 23, 2026
6861934
fix: change 'should' to 'must' in deny rule messages for consistency
Copilot Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions policies/kubernetes/required-labels.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ deny contains msg if {
sc := object.get(container, "securityContext", {})
readOnly := object.get(sc, "readOnlyRootFilesystem", false)
readOnly != true
msg := sprintf("Deployment/%s: container '%s' should use read-only root filesystem", [obj.metadata.name, container.name])
msg := sprintf("Deployment/%s: container '%s' must use read-only root filesystem", [obj.metadata.name, container.name])
}

# Check for liveness and readiness probes
Expand All @@ -66,13 +66,13 @@ deny contains msg if {
obj.kind == "Deployment"
container := obj.spec.template.spec.containers[_]
not container.livenessProbe
msg := sprintf("Deployment/%s: container '%s' should define a livenessProbe", [obj.metadata.name, container.name])
msg := sprintf("Deployment/%s: container '%s' must define a livenessProbe", [obj.metadata.name, container.name])
}

deny contains msg if {
obj := input
obj.kind == "Deployment"
container := obj.spec.template.spec.containers[_]
not container.readinessProbe
msg := sprintf("Deployment/%s: container '%s' should define a readinessProbe", [obj.metadata.name, container.name])
msg := sprintf("Deployment/%s: container '%s' must define a readinessProbe", [obj.metadata.name, container.name])
}