Skip to content

fix: align deny rule messages to use "must" instead of "should"#36

Draft
Copilot wants to merge 2 commits into
argocdcloudfrom
copilot/sub-pr-35
Draft

fix: align deny rule messages to use "must" instead of "should"#36
Copilot wants to merge 2 commits into
argocdcloudfrom
copilot/sub-pr-35

Conversation

Copilot AI commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

Three deny rules in policies/kubernetes/required-labels.rego used advisory "should" wording in their error messages despite being hard-blocking deny rules in Conftest.

Changes

  • policies/kubernetes/required-labels.rego: Updated message wording in three deny rules from "should" → "must":
    • readOnlyRootFilesystem check
    • livenessProbe check
    • readinessProbe check
# Before
msg := sprintf("Deployment/%s: container '%s' should use read-only root filesystem", ...)
msg := sprintf("Deployment/%s: container '%s' should define a livenessProbe", ...)
msg := sprintf("Deployment/%s: container '%s' should define a readinessProbe", ...)

# After
msg := sprintf("Deployment/%s: container '%s' must use read-only root filesystem", ...)
msg := sprintf("Deployment/%s: container '%s' must define a livenessProbe", ...)
msg := sprintf("Deployment/%s: container '%s' must define a readinessProbe", ...)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] [WIP] Address feedback on ArgoCDCloud PR regarding batch inclusion fix: align deny rule messages to use "must" instead of "should" Mar 23, 2026
Copilot AI requested a review from stephenjtyrrell March 23, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants