-
Notifications
You must be signed in to change notification settings - Fork 17
ROX-31352: Move fleetshard-sync to a dedicated chart #2515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kovayur The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
338046c to
2d04062
Compare
2d04062 to
7729574
Compare
7729574 to
e30c12f
Compare
| uses: stackrox/actions/infra/install-infractl@v1 | ||
| - name: Install oc | ||
| uses: redhat-actions/oc-installer@v1 | ||
| - name: Install OpenShift CLI tools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠ Note
This action has been superseded by openshift-tools-installer, which can install oc as well as other CLIs. It has support for caching across multiple workflows, and allows inputting semantic version ranges.
Makefile
Outdated
| @helm uninstall -n "$(NAMESPACE)" emailsender | ||
| @kubectl delete -n "$(NAMESPACE)" -f "dev/env/manifests/emailsender-db" | ||
| @helm uninstall -n "$(NAMESPACE)" emailsender --ignore-not-found | ||
| @oc delete -n "$(NAMESPACE)" -f "dev/env/manifests/emailsender-db" --ignore-not-found=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch to oc to align with other targets
| undeploy/emailsender: | ||
| @helm uninstall -n "$(NAMESPACE)" emailsender | ||
| @kubectl delete -n "$(NAMESPACE)" -f "dev/env/manifests/emailsender-db" | ||
| @helm uninstall -n "$(NAMESPACE)" emailsender --ignore-not-found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add --ignore-not-found to make the command idempotent and not fail if the chart is already uninstalled.
3afce30 to
4f71b33
Compare
|
/retest |
4f71b33 to
9d2f9c5
Compare
Description
deploy/chartsdirectoryChecklist (Definition of Done)
Test manualROX-12345: ...Test manual
TODO: Add manual testing efforts