Skip to content

Conversation

@kovayur
Copy link
Contributor

@kovayur kovayur commented Dec 15, 2025

Description

  • move the fleetshard-sync app from the dp-terraform chart to a dedicated helm chart under the deploy/charts directory
  • delete dp-terraform folder
  • remove the helm-based operator from the fleetshard-operator image
  • use the new fleetshard-sync helm chart in the E2E tests instead

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

uses: stackrox/actions/infra/install-infractl@v1
- name: Install oc
uses: redhat-actions/oc-installer@v1
- name: Install OpenShift CLI tools
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠ Note
This action has been superseded by openshift-tools-installer, which can install oc as well as other CLIs. It has support for caching across multiple workflows, and allows inputting semantic version ranges.

Makefile Outdated
@helm uninstall -n "$(NAMESPACE)" emailsender
@kubectl delete -n "$(NAMESPACE)" -f "dev/env/manifests/emailsender-db"
@helm uninstall -n "$(NAMESPACE)" emailsender --ignore-not-found
@oc delete -n "$(NAMESPACE)" -f "dev/env/manifests/emailsender-db" --ignore-not-found=true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch to oc to align with other targets

undeploy/emailsender:
@helm uninstall -n "$(NAMESPACE)" emailsender
@kubectl delete -n "$(NAMESPACE)" -f "dev/env/manifests/emailsender-db"
@helm uninstall -n "$(NAMESPACE)" emailsender --ignore-not-found
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add --ignore-not-found to make the command idempotent and not fail if the chart is already uninstalled.

@kovayur
Copy link
Contributor Author

kovayur commented Dec 23, 2025

/retest

@kovayur kovayur changed the title WIP: ROX-31352: Move fleetshard-sync to a dedicated chart ROX-31352: Move fleetshard-sync to a dedicated chart Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant