Use go-containerregistry for OCI tag validation#4017
Open
Conversation
Replace the hand-rolled regex in validateOCITag with go-containerregistry's nameref.NewTag using StrictValidation. This delegates tag validation to the same library already used for OCI reference parsing, avoiding drift from the distribution spec. Add table-driven tests for validateOCITag covering valid tags (versions, hyphens, dots, underscores, boundary lengths) and invalid tags (special characters, empty, over-length). Relates to #4015 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
size/XS
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4017 +/- ##
==========================================
- Coverage 68.62% 68.56% -0.06%
==========================================
Files 444 444
Lines 45222 45222
==========================================
- Hits 31033 31006 -27
- Misses 11790 11819 +29
+ Partials 2399 2397 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
added
size/XS
aponcedeleonch
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
^[\w][\w.-]{0,127}$) invalidateOCITagwithgo-containerregistry'snameref.NewTagusingStrictValidationparseOCIReference, avoiding drift from the distribution specvalidateOCITagcovering valid and invalid tagsRelates to #4015
Test plan
TestValidateOCITagpasses (16 cases: valid versions, hyphens, dots, underscores, boundary lengths; invalid special chars, empty, over-length)TestBuildpasses (includesinvalid_tag_returns_400case)skillsvctest suite passes🤖 Generated with Claude Code