Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions plugins/Rootly/v1/dataStreams/incidents.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,28 @@
{
"name": "incidents",
Comment thread
noorulkhan-n marked this conversation as resolved.
"tags": ["Incidents"],
"config": {
"httpMethod": "get",
"paging": {
"mode": "offset",
"pageSize": {
"realm": "queryArg",
"path": "page[size]",
"value": "200"
},
"offset": {
"rowCountIn": {
"realm": "payloadArraySize",
"path": "data"
},
"mode": "page",
"base": "1"
},
"out": {
"realm": "queryArg",
"path": "page[number]"
}
},
"expandInnerObjects": true,
"endpointPath": "incidents",
"getArgs": [
Expand All @@ -12,14 +33,6 @@
{
"key": "filter[{{timestampField}}][lte]",
"value": "{{{timeframe.end}}}"
},
{
"key": "page[number]",
"value": "1"
},
{
"key": "page[size]",
"value": "100"
}
],
"postRequestScript": "incidents.js",
Expand Down
3 changes: 1 addition & 2 deletions plugins/Rootly/v1/metadata.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "rootly",
"displayName": "Rootly",
"version": "1.0.2",
"version": "1.0.3",
"author": {
"name": "@noorulkhan-n",
"type": "community"
Expand All @@ -20,13 +20,12 @@
{
"value": "Bearer {{apiKey}}",
"key": "Authorization"
}
],
"queryArgs": [],
"modules": [],
"authMode": "none",
Comment thread
claude[bot] marked this conversation as resolved.
"baseUrl": "https://api.rootly.com/v1/"
}

Check notice on line 28 in plugins/Rootly/v1/metadata.json

View check run for this annotation

Claude / Claude Code Review

Missing documentation link and README

🟣 **Pre-existing nit:** The Rootly plugin has no `docs/README.md` and `metadata.json` only includes a `source` link β€” no `documentation` link. The repo guidelines say `links` should "typically contain two" (source and documentation), and the documentation link is what powers the "Need help?" panel in the SquaredUp configuration UI (handy for telling users where to obtain a Rootly API key). This predates the PR and is not blocking β€” entirely optional follow-up, since adding it would mean authorin
Comment thread
noorulkhan-n marked this conversation as resolved.
},
"links": [
{
Expand Down
Loading