Skip to content

Add paging support to Rootly- incidents datastream#64

Merged
noorulkhan-n merged 4 commits into
mainfrom
feature/rootly_paging
Jun 22, 2026
Merged

Add paging support to Rootly- incidents datastream#64
noorulkhan-n merged 4 commits into
mainfrom
feature/rootly_paging

Conversation

@noorulkhan-n

@noorulkhan-n noorulkhan-n commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

📋 Summary

  • Added offset-based paging support for the incidents datastream.
  • Configured page size and offset handling to retrieve all records across multiple pages.
  • Ensures incident imports continue correctly when API responses exceed a single page.

🧩 Plugin details

  • Plugin name:

  • Type of change:

    • Bug fix
    • New datastream
    • Enhancement to existing datastream
    • Performance improvement
    • Documentation / metadata / logo
    • Other (please describe)

⚠️ Breaking changes

  • No
  • Yes (please describe)

📚 Documentation

  • No documentation changes needed
  • Documentation updated

✅ Checklist

  • No secrets or credentials included
  • Plugin, datastream and UI naming follow SquaredUp guidelines
  • I agree to the Code of Conduct

@noorulkhan-n noorulkhan-n requested a review from a team June 16, 2026 05:59
@noorulkhan-n noorulkhan-n added the enhancement New feature or request label Jun 16, 2026
@clarkd

clarkd commented Jun 17, 2026

Copy link
Copy Markdown
Member

@claude review

@clarkd

clarkd commented Jun 17, 2026

Copy link
Copy Markdown
Member

Hi @noorulkhan-n - please update the PR description to use one of the templates in the current PR description.

@noorulkhan-n

Copy link
Copy Markdown
Contributor Author

@clarkd updated the description now

@clarkd

clarkd commented Jun 17, 2026

Copy link
Copy Markdown
Member

@claude review once

Comment thread plugins/Rootly/v1/metadata.json

@clarkd clarkd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version bump required, but the rest of the change looks good

@noorulkhan-n

Copy link
Copy Markdown
Contributor Author

@clarkd version incremented

Comment thread plugins/Rootly/v1/dataStreams/incidents.json
@github-actions

Copy link
Copy Markdown

🧩 Plugin PR Summary

📦 Modified Plugins

  • plugins/Rootly/v1

📋 Results

Step Status
Validation ✅ Passed
Deployment 🚀 Deployed

🔍 Validation Details

rootly
{
  "valid": true,
  "pluginName": "rootly",
  "pluginType": "cloud",
  "summary": {
    "Data Streams": 1,
    "Import Definitions": 0,
    "UI Configuration": true,
    "Has Icon": true,
    "Has Default Content": false,
    "Config Validation": false,
    "Custom Types": false
  }
}

@clarkd

clarkd commented Jun 19, 2026

Copy link
Copy Markdown
Member

@claude review once

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All prior feedback addressed (version bump, tags added) — straightforward paging config enhancement.

Extended reasoning...

Overview

This PR adds offset-based paging configuration to the Rootly incidents data stream (page size 200, using the WebAPI paging block with mode: offset and mode: page), bumps the plugin version to 1.0.3, removes the unrecognized modules: [] key, and adds a top-level tags: ["Incidents"] field on the data stream. Only two files are touched: plugins/Rootly/v1/dataStreams/incidents.json and plugins/Rootly/v1/metadata.json.

Security risks

None. This is a declarative JSON config change to an existing data stream — no script execution paths, no auth changes, no new secrets, no URL changes. The Authorization: Bearer {{apiKey}} header is untouched.

Level of scrutiny

Low. This is a small, mechanical config-only change following the established WebAPI paging pattern used elsewhere in the repo. The PR's footprint is two JSON files within one plugin's v1 directory, and the changes are easy to reason about line-by-line from the diff.

Other factors

The author has responded to both of my prior reviews — the version bump (1.0.2 → 1.0.3) was added after my first review, and the tags field was added after my second review. The CI plugin validation also passed and reports a successful deployment. The only outstanding item is a pre-existing nit about the missing docs/README.md and documentation link, which I've explicitly noted is not blocking. Nothing here warrants holding up the merge.

Comment thread plugins/Rootly/v1/metadata.json
@noorulkhan-n noorulkhan-n merged commit e2c62f6 into main Jun 22, 2026
2 of 4 checks passed
@noorulkhan-n noorulkhan-n deleted the feature/rootly_paging branch June 22, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request plugin: Rootly

Development

Successfully merging this pull request may close these issues.

2 participants