Add support Camel Case for key to avoid crash#36
Add support Camel Case for key to avoid crash#36vsay01 wants to merge 1 commit intosquare:masterfrom
Conversation
|
You'd have to adjust tests, too. For what it's worth, there's already #35 that clarifies the error messages. |
|
@pforhan It seems test case illegalTokenCharactersFailFast will fail if we use Camel Case for the token. Also in #35 there is a test case putFailUppercaseNotAllowedMiddle as well. For my case, i need to have Camel Case that's why I thought it would be useful for others as well. Would love to hear the direction from you, I can either close this PR or fix the unit test. Thanks |
|
For now I fix the unit tests in my local branch, and all the test cases are passed. |
|
If you look at the issue history (like #9) , there's not been a lot of desire for it, that's why I beefed up the error messages and tests to be more explicit about the expected key format. |
|
@pforhan Thanks for the information. I will close this pull request as the library won't support the Upper case as the choice of the library as mentioned in #9.
Thanks for the library. |
Hopefully it support the camel case for the key