Skip to content

More clear error messages for invalid characters#35

Merged
loganj merged 2 commits intosquare:masterfrom
pforhan:master
Oct 17, 2017
Merged

More clear error messages for invalid characters#35
loganj merged 2 commits intosquare:masterfrom
pforhan:master

Conversation

@pforhan
Copy link
Contributor

@pforhan pforhan commented Jul 21, 2017

Tweaks invalid start- and end-of-token messages for clarity.

Inspired by #33, fixes #32 and fixes #34, probably #29 as well.

@pforhan pforhan mentioned this pull request Jul 21, 2017
@pforhan
Copy link
Contributor Author

pforhan commented Jul 21, 2017

Not sure what's up with the CI build, a ./gradlew clean build comes back successful for me.

@pforhan
Copy link
Contributor Author

pforhan commented Jul 21, 2017

ci says:

failed to find target with hash string 'android-23' in: /usr/local/android-sdk

@zach-klippenstein
Copy link
Collaborator

LGTM 👌

Tweaks invalid start- and end-of-token messages for clarity.

Inspired by square#33, fixes square#32 and square#34, probably square#29 as well.
@pforhan
Copy link
Contributor Author

pforhan commented Jul 26, 2017

Pushed a small change to help users differentiate the first-character message from the error later on.

@pforhan
Copy link
Contributor Author

pforhan commented Aug 14, 2017

@JakeWharton @rjrjr @loganj anyone interested in merging this?

@rjrjr
Copy link
Contributor

rjrjr commented Aug 14, 2017

LGTM, but can we figure out why the Travis is failing?

@pforhan
Copy link
Contributor Author

pforhan commented Aug 14, 2017

I think this is it:

Package Android SDK Platform-tools, revision 26 not installed due to rejected license 'android-sdk-license-c81a61d9'.

@pforhan
Copy link
Contributor Author

pforhan commented Aug 14, 2017

That passed. Pushed a small formatting fix for the .travis.yml file

@pforhan
Copy link
Contributor Author

pforhan commented Aug 14, 2017

Sigh, and another -- I added the newline to the wrong place

@pforhan
Copy link
Contributor Author

pforhan commented Aug 14, 2017

Green!

@pforhan
Copy link
Contributor Author

pforhan commented Oct 16, 2017

Can I get a merge here? I think this is a good usability improvement that will head off more issues like #36

@loganj loganj merged commit 66a2dc9 into square:master Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants