Skip to content

fix: CU-2377 scip-go is logging errors that should be classified as warnings #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrapkowski-sg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: CU-2377 scip-go is logging errors that should be classified as warnings #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions internal/loader/loader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,13 +250,10 @@ func normalizePackage(opts *config.IndexOpts, pkg *packages.Package) *packages.P
if pkg.Module.Path == opts.ModulePath {
pkg.Module.Version = opts.ModuleVersion
} else {
// Only panic when running in debug mode.
log.Error(handler.ErrOrPanic(
"Unknown version for userland package: %s %s",
pkg.Module.Path,
opts.ModulePath,
))

log.Warn("Unknown version for userland package, using fallback",
"module", pkg.Module.Path,
"mainModule", opts.ModulePath,
)
pkg.Module.Version = "."
}
} else if module.IsPseudoVersion(pkg.Module.Version) {
Expand All @@ -266,12 +263,10 @@ func normalizePackage(opts *config.IndexOpts, pkg *packages.Package) *packages.P
// the revision from a pseudo-version.
rev, err := module.PseudoVersionRev(pkg.Module.Version)
if err != nil {
// Only panic when running in debug mode.
log.Error(handler.ErrOrPanic(
"Unable to find rev from pseudo-version: %s %s",
pkg.Module.Path,
pkg.Module.Version,
))
log.Warn("Unable to find rev from pseudo-version, using original",
"module", pkg.Module.Path,
"version", pkg.Module.Version,
)
} else {
pkg.Module.Version = rev
}
Expand Down