fix: CU-2377 scip-go is logging errors that should be classified as warnings#178
Open
chrapkowski-sg wants to merge 1 commit intomainfrom
Open
fix: CU-2377 scip-go is logging errors that should be classified as warnings#178chrapkowski-sg wants to merge 1 commit intomainfrom
chrapkowski-sg wants to merge 1 commit intomainfrom
Conversation
Author
|
This change is part of the following stack: Change managed by git-spice. |
peterguy
requested changes
Feb 4, 2026
peterguy
left a comment
There was a problem hiding this comment.
Based on the Slack discussion this is probably not the correct solution. The actual fix is probably handling multi-module repos in normalizePackage, not silencing the log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes log.Error to log.Warn for two conditions in the package loader that are recoverable edge cases with explicit fallbacks, not actual errors:
Both conditions have graceful fallbacks and don't indicate failures. Logging them as ERROR was misleading and noisy in production logs.
I removed ErrOrPanic call since we do not do this in other places where we log a
warnfor examplescip-go/internal/loader/loader.go
Line 111 in 05ce6e6