Skip to content

docs: add sm_utils pages and fix semantic metric catalog docs#7

Closed
lordhumunguz wants to merge 1 commit intomasterfrom
fix/reporting-queries-docs
Closed

docs: add sm_utils pages and fix semantic metric catalog docs#7
lordhumunguz wants to merge 1 commit intomasterfrom
fix/reporting-queries-docs

Conversation

@lordhumunguz
Copy link
Contributor

@lordhumunguz lordhumunguz commented Jan 30, 2026

Adds a minimal docs section for sm_utils (index + table stubs), fixes semantic metric catalog docs wording around filter_condition and trailing windows, and updates docs.json nav.\n\nNote: This branch is referenced by reporting_queries PR fix/semantic-metadata-docs via submodule pointer.

Summary by CodeRabbit

Release Notes

  • Documentation
    • Enhanced metric filter descriptions with clearer documentation of NULL cases
    • Added comprehensive guides for new utility tables: daily currency conversion rates, date dimensions, and country reference data
    • Organized utility resources under a new "Utility Tables" navigation section for easier discovery
    • Clarified Cost Per Acquisition (CPA) metric definition

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 30, 2026

📝 Walkthrough

Walkthrough

This pull request adds new documentation for utility tables (dim_dates, currency_conversion_rates_daily, geo_countries), updates the navigation structure to expose these tables, and refines existing metric documentation descriptions for clarity and consistency.

Changes

Cohort / File(s) Summary
Metric Documentation Clarifications
data-activation/data-tables/sm_metadata/dim_semantic_metric_catalog.mdx, onboarding/data-docs/metrics.mdx
Updated descriptions to clarify filter_condition extraction behavior and CPA metric definition, with minor grammatical adjustments (e.g., "30 day" → "30 days").
New Utility Table Documentation
data-activation/data-tables/sm_utils/currency_conversion_rates_daily.mdx, data-activation/data-tables/sm_utils/dim_dates.mdx, data-activation/data-tables/sm_utils/geo_countries.mdx
Added new MDX documentation files describing three utility tables: daily FX conversion rates, shared date dimension, and country reference data, including overview and common use cases.
Utility Tables Navigation
data-activation/data-tables/sm_utils/index.mdx, docs.json
Created index documentation page for sm_utils utilities and added "Utility Tables" navigation group to docs.json with links to dim_dates, currency_conversion_rates_daily, and geo_countries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 New tables spring forth, organized with care,
Documentation paths now abundant and fair,
From currencies to dates, a reference divine,
Utility tables arranged in a grid so fine! 📊✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: adding sm_utils documentation pages and fixing semantic metric catalog documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/reporting-queries-docs

Tip

🧪 Unit Test Generation v2 is now available!

We have significantly improved our unit test generation capabilities.

To enable: Add this to your .coderabbit.yaml configuration:

reviews:
  finishing_touches:
    unit_tests:
      enabled: true

Try it out by using the @coderabbitai generate unit tests command on your code files or under ✨ Finishing Touches on the walkthrough!

Have feedback? Share your thoughts on our Discord thread!


Comment @coderabbitai help to get the list of available commands and usage tips.

@lordhumunguz
Copy link
Contributor Author

Closing since we’re not taking mintlify/docs content changes in this reporting_queries PR; submodule is being pinned to upstream origin/master instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant