Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sharp-rooms-think.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@solidjs/start": patch
---

Handle multiple exports from the same file in fs-router
5 changes: 5 additions & 0 deletions .changeset/ten-areas-burn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@solidjs/start": patch
---

Add a test route for multiple exports handling and correct variable typos
22 changes: 11 additions & 11 deletions packages/start/config/fs-router.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { analyzeModule, BaseFileSystemRouter, cleanPath } from "vinxi/fs-router";
import {analyzeModule, BaseFileSystemRouter, cleanPath} from "vinxi/fs-router";

export class SolidStartClientFileRouter extends BaseFileSystemRouter {
toPath(src) {
Expand Down Expand Up @@ -43,13 +43,13 @@ export class SolidStartClientFileRouter extends BaseFileSystemRouter {
page: true,
$component: {
src: src,
pick: ["default", "$css"]
pick: [...exports.filter(e => e.n === e.ln && e.n !== "route").map(e => e.n), "default", "$css"]
},
$$route: hasRouteConfig
? {
src: src,
pick: ["route"]
}
src: src,
pick: ["route"]
}
: undefined,
path,
filePath: src
Expand Down Expand Up @@ -123,15 +123,15 @@ export class SolidStartServerFileRouter extends BaseFileSystemRouter {
$component:
!this.config.dataOnly && hasDefault
? {
src: src,
pick: ["default", "$css"]
}
src: src,
pick: [...exports.filter(e => e.n === e.ln && e.n !== "route" && !HTTP_METHODS.includes(e.n)).map(e => e.n), "default", "$css"]
}
: undefined,
$$route: hasRouteConfig
? {
src: src,
pick: ["route"]
}
src: src,
pick: ["route"]
}
: undefined,
...createHTTPHandlers(src, exports),
path,
Expand Down
3 changes: 3 additions & 0 deletions packages/tests/src/app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ export default function App() {
<li>
<a href="/generator-server-function">generator server function</a>
</li>
<li>
<a href="/referencing-multiple-export-named-functions-in-the-same-file">referencing multiple export named functions in the same file</a>
</li>
</ul>
<Suspense>{props.children}</Suspense>
</MetaProvider>
Expand Down
4 changes: 4 additions & 0 deletions packages/tests/src/functions/text-render-test-component.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
export function TextRenderTestComponent() {
const text = "(´。> ᵕ <。`) ♡";
return <>{text}</>;
}
4 changes: 2 additions & 2 deletions packages/tests/src/routes/is-server-const.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ export default function App() {


createEffect(async () => {
const restult = await serverFnWithIsServer();
setOutput(prev => ({ ...prev, serverFnWithIsServer: restult }));
const result = await serverFnWithIsServer();
setOutput(prev => ({ ...prev, serverFnWithIsServer: result }));
});


Expand Down
4 changes: 2 additions & 2 deletions packages/tests/src/routes/is-server-nested.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ export default function App() {


createEffect(async () => {
const restult = await serverFnWithIsServer();
setOutput(prev => ({ ...prev, serverFnWithIsServer: restult }));
const result = await serverFnWithIsServer();
setOutput(prev => ({ ...prev, serverFnWithIsServer: result }));
});


Expand Down
4 changes: 2 additions & 2 deletions packages/tests/src/routes/is-server-toplevel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ export default function App() {


createEffect(async () => {
const restult = await serverFnWithIsServer();
setOutput(prev => ({ ...prev, serverFnWithIsServer: restult }));
const result = await serverFnWithIsServer();
setOutput(prev => ({ ...prev, serverFnWithIsServer: result }));
});


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ export default function App() {


createEffect(async () => {
const restult = await serverFnWithIsServer();
setOutput(prev => ({ ...prev, serverFnWithIsServer: restult }));
const result = await serverFnWithIsServer();
setOutput(prev => ({ ...prev, serverFnWithIsServer: result }));
});


Expand Down
4 changes: 2 additions & 2 deletions packages/tests/src/routes/node-builtin-nested.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ export default function App() {


createEffect(async () => {
const restult = await serverFnWithNodeBuiltin();
setOutput(prev => ({ ...prev, serverFnWithNodeBuiltin: restult }));
const result = await serverFnWithNodeBuiltin();
setOutput(prev => ({ ...prev, serverFnWithNodeBuiltin: result }));
});

return (
Expand Down
4 changes: 2 additions & 2 deletions packages/tests/src/routes/node-builtin-toplevel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ export default function App() {
const [output, setOutput] = createSignal<{ serverFnWithNodeBuiltin?: string }>({});

createEffect(async () => {
const restult = await serverFnWithNodeBuiltin();
setOutput(prev => ({ ...prev, serverFnWithNodeBuiltin: restult }));
const result = await serverFnWithNodeBuiltin();
setOutput(prev => ({ ...prev, serverFnWithNodeBuiltin: result }));
});

return (
Expand Down
4 changes: 2 additions & 2 deletions packages/tests/src/routes/npm-module-nested.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ export default function App() {
const [output, setOutput] = createSignal<{ serverFnWithNpmModule?: number[] }>({});

createEffect(async () => {
const restult = await serverFnWithNpmModule();
setOutput(prev => ({ ...prev, serverFnWithNpmModule: restult }));
const result = await serverFnWithNpmModule();
setOutput(prev => ({ ...prev, serverFnWithNpmModule: result }));
});

return (
Expand Down
4 changes: 2 additions & 2 deletions packages/tests/src/routes/npm-module-toplevel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ export default function App() {
const [output, setOutput] = createSignal<{ serverFnWithNpmModule?: number[] }>({});

createEffect(async () => {
const restult = await serverFnWithNpmModule();
setOutput(prev => ({ ...prev, serverFnWithNpmModule: restult }));
const result = await serverFnWithNpmModule();
setOutput(prev => ({ ...prev, serverFnWithNpmModule: result }));
});

return (
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import { TextRenderTestComponent as ExternalCuteFaceDisplay} from "../functions/text-render-test-component";

export function TextRenderTestComponent() {
return <>(´。• ᵕ •。`) ♡</>;
}

export function VariableImportTestComponent() {
return <>{testObjectExport.stringValue}</>;
}

export const testStringExport = "♡(˃͈ દ ˂͈ ༶ )";

export const testObjectExport = {
stringValue: testStringExport,
};

export default function () {
return <>
<TextRenderTestComponent/>
<VariableImportTestComponent/>
<ExternalCuteFaceDisplay/>
</>;
}
Loading