fix: Handle multiple exports from the same file in fs-router#1936
Merged
atilafassina merged 1 commit intosolidjs:mainfrom Sep 10, 2025
Merged
fix: Handle multiple exports from the same file in fs-router#1936atilafassina merged 1 commit intosolidjs:mainfrom
atilafassina merged 1 commit intosolidjs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 98f6c5f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
More templates
commit: |
This was referenced Aug 10, 2025
dennev
force-pushed
the
fix/File-System-Routing
branch
from
b02fcc5 to
404c0ac
Compare
Contributor
|
This solves the 3 open issues? That would be great. Ill take a bit of a look here |
brenelz
reviewed
Aug 19, 2025
brenelz
reviewed
Aug 19, 2025
packages/tests/src/routes/referencing-multiple-export-named-functions-in-the-same-file.tsx
Show resolved
Hide resolved
dennev
force-pushed
the
fix/File-System-Routing
branch
from
404c0ac to
acdd3bb
Compare
Collaborator
|
This is a decent solution, though after devinxi I might look at adding an |
Contributor
|
@Brendonovich so we should merge this in? |
dennev
force-pushed
the
fix/File-System-Routing
branch
from
10e5ba4 to
062b609
Compare
brenelz
approved these changes
Sep 2, 2025
test: add a test route for multiple exports handling and correct variable typos chore: add changeset for handling multiple exports in fs-router and tests
atilafassina
force-pushed
the
fix/File-System-Routing
branch
from
062b609 to
98f6c5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
If a default function in the file routes folder references an export function in the same file, a not defined error occurs and cannot be rendered.
What is the new behavior?
The hydration process works even when the default function and its multiple referenced export functions are in the same file.
Other information