Open
Conversation
mdydek
requested changes
Mar 2, 2026
Contributor
mdydek
left a comment
mdydek
left a comment
There was a problem hiding this comment.
- highlighted parts can overlap each other and it does not look appealing (oscillator page)
- lines for highlighted links do not end with the end of word, but they spread across all highlighted area (oscillator page), also they are doubled, removal of a line in
typography.cssfile, fixes the issue
border-bottom: 1px solid var(--ifm-font-color-base);
- all interactive playgrounds have weird spacing between code part and interactive part
- highlighting colors in warning looks still off (decoding page)
- on first render of oscillator interactive playground there is no line visible, whereas f.e. in audiobuffersource one it is visible
Collaborator
maciejmakowski2003
left a comment
maciejmakowski2003
left a comment
There was a problem hiding this comment.
great work, it looks really fresh. I have a few remarks:
- do we still want to use blue for badges like below?
-
maybe let's use red for warning/caution(or only yellow), blue for info, green for good practice/tip?
-
blue for files drop downs? what's the exact convention?
|
|
||
| import OscillatorSquare from '@site/src/components/OscillatorSquare'; | ||
|
|
||
| <OscillatorSquare /> |
Collaborator
There was a problem hiding this comment.
that red color backlight is really annoying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes RNAA-237
Introduced changes
Checklist