Conversation
macro values may vary across OS
|
Hey, thanks for the PR! Could you provide some comments on which OSes deviate from the constants here? Originally this project is targeted primarily at Linux and I'm not aware of which other OSes support O_DIRECT; e.g. I don't see it in BSD. Also, I'm not too fond of the idea of spinning up another process in a statically-scoped context, but it's been a while since I've used Java so maybe this sort of thing is standard practice? Either way I'd prefer a different approach that doesn't require spawning other processes, and that has the current constants available as a fallback in case something goes wrong. |
|
My comment was not clear, I meant across Linux distros. The hardcoded macro value in |
|
Thanks for the extra context! Which distro had different constants from the hardcoded ones? |
|
It's |
macro values may vary across OSes