Fix some usability issues + parse flags from libc sources if possible#8
Open
chhh wants to merge 20 commits intosmacke:masterfrom
Open
Fix some usability issues + parse flags from libc sources if possible#8chhh wants to merge 20 commits intosmacke:masterfrom
chhh wants to merge 20 commits intosmacke:masterfrom
Conversation
…length. If channel length is zero, set the fileLength to Long.MAX_VALUE.
Some updates
Fix a bug and bump the version.
Owner
|
Hey, thanks for the PR. I'm a bit concerned about spawning a new process like this for parsing out the various flags -- see my comment on #7. What are the OSes that support O_DIRECT that could have different values for these flags? Is there a way we could get this information without spawning a new process inside a static context, and include the original defaults as fallbacks? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turned out flags might differ on some systems, should be a benign change