-
Notifications
You must be signed in to change notification settings - Fork 26
build: run the docgen command with make tag release #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
==========================================
- Coverage 62.96% 62.95% -0.02%
==========================================
Files 212 212
Lines 21782 21782
==========================================
- Hits 13715 13712 -3
Misses 7005 7005
- Partials 1062 1065 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mwbrooks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Love this iteration and honestly it feel safer than having a workflow that will make a commit.
📝 I left a minor suggestion to skip the upgrade prompt, which I came across while testing.
Co-authored-by: Michael Brooks <mbrooks@slack-corp.com>
|
Very nice! 🚀 time! |
|
@mwbrooks Thanks tons! Tests are passing now so we can merge this in hopes for a good release process next! 🚀 |
|
@mwbrooks 🗣️ ramble: Oops I hit send so soon - meant to agree that a commit on machine can be faster in current setups! |
Summary
This PR follows up on #228 and adds the
docgencommand to the "make tag" release script. Might substitute #197?Preview
tag.mov
Reviewers
Please feel free to comment out the "diff" and "commit" and "tag" steps for fast testing:
Then confirm reference is regenerated and versions are updated as expected!
Notes
I'm still interested in the PR approach @lukegalbraithrussell shares in #197 in quest to automate more releases, but for now I think this'll match our current processes 👾
Requirements