-
Notifications
You must be signed in to change notification settings - Fork 26
docs(ci): adds generated reference workflow #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
==========================================
- Coverage 62.94% 62.92% -0.03%
==========================================
Files 212 212
Lines 21782 21782
==========================================
- Hits 13711 13706 -5
- Misses 7009 7012 +3
- Partials 1062 1064 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| on: | ||
| workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👁️🗨️ thought: Adding on "version" tags might be interesting! Otherwise we will need to add this to our release runbooks.
📣 ramble: So open to saving this for follow ups of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗣️ note: Ugh that was more clear in mind... I meant to suggest "on new tagged releases the workflow should run" but I forget the syntax!
|
|
||
| - name: Generate a GitHub token | ||
| id: ghtoken | ||
| uses: actions/create-github-app-token@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💔 todo: We should use pinned versions here though I don't think the healthscore has released such a check yet...
📫 note: I can soon add these versions if needed!
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| update-docs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔐 todo: This'll also need some set of permissions. Do let me know if I can help with this!
|
🗣️ Removed this from the next milestone for now. I think we want to refine our release process to autogenerate docs during the tag? IIRC suggestion has been floated for: And perhaps this can be included in workflows somehow in the future? |
|
@lukegalbraithrussell Thanks for starting conversation on how we keep documentation current with a changing release process! A change to use the following command landed in #228 for improving how we update installation links and #229 was opened to include similar I'm so curious if we can follow up on these to use PRs as part of our release process automations - let's continue these explorations? 👾 |
|
🗣️ Wanting to keep track of our progress in automating these updates! The above PRs were a success in the most recent release v3.8.0! Some follow up seems needed still though:
I'm open to keeping this PR around for more discussion on this topic! |
Summary
This PR adds a manual dispatch workflow to be run after release to update the CLI reference docs
This PR also manually updates the CLI reference docs using the recently updated version of
docgennow inmain.I have a PR preview of this but idk if i should be dropping the link in a public PR hmmm
Requirements