Skip to content

Use BitmapFactory on old versions of Android #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dfabulich wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use BitmapFactory on old versions of Android #446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions Sources/SkipUI/SkipUI/UIKit/UIImage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,13 @@
#if !SKIP_BRIDGE
import Foundation
#if SKIP
import android.content.Context
import android.content.ContentResolver
import android.graphics.Bitmap
import android.graphics.BitmapFactory
import android.graphics.ImageDecoder
import android.net.Uri
import android.os.Build
import java.nio.ByteBuffer
import android.graphics.Bitmap
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.withContext
#endif
Expand All @@ -16,6 +18,22 @@ import kotlinx.coroutines.withContext
public class UIImage {
#if SKIP
let bitmap: Bitmap?

private static func decodeBitmapFromData(bytes: kotlin.ByteArray) -> Bitmap? {
if Build.VERSION.SDK_INT >= Build.VERSION_CODES.P {
let source = ImageDecoder.createSource(ByteBuffer.wrap(bytes))
return ImageDecoder.decodeBitmap(source)
}
return BitmapFactory.decodeByteArray(bytes, 0, bytes.size)
}

private static func decodeBitmapFromUri(contentResolver: ContentResolver, uri: Uri) -> Bitmap? {
if Build.VERSION.SDK_INT >= Build.VERSION_CODES.P {
let source = ImageDecoder.createSource(contentResolver, uri)
return ImageDecoder.decodeBitmap(source)
}
return contentResolver.openInputStream(uri)?.use { stream in BitmapFactory.decodeStream(stream) }
}
#endif

@available(*, unavailable)
Expand Down Expand Up @@ -122,9 +140,8 @@ public class UIImage {
do {
let contentResolver = ProcessInfo.processInfo.androidContext.getContentResolver()
let uri = Uri.parse(path)
let source = ImageDecoder.createSource(contentResolver, uri)

guard let bitmap = ImageDecoder.decodeBitmap(source) else {
guard let bitmap = Self.decodeBitmapFromUri(contentResolver: contentResolver, uri: uri) else {
return nil
}

Expand All @@ -147,9 +164,8 @@ public class UIImage {
#if SKIP
do {
let bytes = data.kotlin(nocopy: true)
let source = ImageDecoder.createSource(ByteBuffer.wrap(bytes))

guard let bitmap = ImageDecoder.decodeBitmap(source) else {
guard let bitmap = Self.decodeBitmapFromData(bytes: bytes) else {
return nil
}

Expand Down
Loading