Skip to content

Use BitmapFactory on old versions of Android#446

Open
dfabulich wants to merge 1 commit into
skiptools:mainfrom
dfabulich:imagedecoder-compat
Open

Use BitmapFactory on old versions of Android#446
dfabulich wants to merge 1 commit into
skiptools:mainfrom
dfabulich:imagedecoder-compat

Conversation

@dfabulich
Copy link
Copy Markdown
Contributor

ImageDecoder was introduced in API level 28 (P)

Skip Pull Request Checklist:

  • REQUIRED: I have signed the Contributor Agreement
  • REQUIRED: I have tested my change locally with swift test
  • OPTIONAL: I have tested my change on an iOS simulator or device
  • OPTIONAL: I have tested my change on an Android emulator or device
  • REQUIRED: I have checked whether this change requires a corresponding update in the Skip Fuse UI repository (link related PR if applicable)
    Not required
  • OPTIONAL: I have added an example of any UI changes to the Showcase sample app
    Support Android 7 (API level 24) skipapp-showcase#108

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

Cursor did a first draft; I refactored it. I tested it using skiptools/skipapp-showcase#108

`ImageDecoder` was introduced in API level 28 (P)
@dfabulich
Copy link
Copy Markdown
Contributor Author

I don't repro this CI failure on my machine. swift test passes for me.

@marcprux
Copy link
Copy Markdown
Member

I don't repro this CI failure on my machine. swift test passes for me.

I'm seeing this on the main branch as well, probably a side effect of skip 1.9 and skiptools/skip#697

I'll fix the test cases, since these sorts of cosmetic drifts are not uncommon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants