Merged
Conversation
go_to will now accept az=None and/or el=None, in which case the mode for the axis will not be changed. This is an interface change, but the behavior is backwards compatible with current common usage. This is required for star camera surveys with elevation either in Stop or Preset.
BrianJKoopman
approved these changes
May 20, 2025
Member
BrianJKoopman
left a comment
There was a problem hiding this comment.
Looks good to me.
It looks like with az and el both optional on go_to that if both are omitted it would be equivalent to a go_to to the current location and wouldn't change modes, is that right?
Member
Author
It is a no-op in that case -- the code will basically check that the current position is Sun Safe. So it might return an error (not sun safe), but regardless it will return without doing anything to either axis. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
go_towill now acceptaz=Noneand/orel=None, in which case the mode for the axis will not be changed. This is an interface change, but the behavior is backwards compatible with current common usage.Motivation and Context
This is required for star camera surveys, where it is desirable to command azimuth moves while either holding elevation in Stop, or in Preset.
How Has This Been Tested?
Tested with ACU simulator from soaculib. Interface tested with current ocs-web (which does not propagate az=null, el=null) and an updated ocs-web that can activate the feature.
Types of changes
Checklist: