ACU Agent: fix bug that prevents go_to#884
Merged
BrianJKoopman merged 1 commit intomainfrom May 21, 2025
Merged
Conversation
Changing how axes modes are set results in slightly different ok message...
BrianJKoopman
approved these changes
May 21, 2025
Member
BrianJKoopman
left a comment
There was a problem hiding this comment.
Thanks! Updating the simulator with the new return string sounds good too.
laurensaunders
pushed a commit
that referenced
this pull request
Feb 19, 2026
Changing how axes modes are set results in slightly different ok message...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In cases where we check the ACU reply text to see if it indicates success, check against a short list of known "OK_responses".
This corrects a bug that makes the ACU Agent from #880 totally unusable at the site.
Motivation and Context
Most ACU commands return the success text "OK, Command executed." But some say "OK, Command send." Recent evolutions in soaculib and socs ended up using one of those latter commands, which prevented the agent from believing it had commanded successfully.
How Has This Been Tested?
Tested moves and scans on the ACU simulator, after updating it to return the second OK response, like a real ACU.
Types of changes
Checklist: