Add disappearing message time of 3 weeks

[narzb]

This adds 3 weeks to the selectable times for disappearing messages.
1 week maximum is too short for certain uses.

(I added the word // FREEBIE)

• I have read how to contribute to this project

• I have signed the Contributor License Agreement

• I am following the Code Style Guidelines

• I have tested my contribution on these devices:

• Virtual device Nexus 5, Android 6.0

• My contribution is fully baked and ready to be merged as is
• I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax
• I have made the choice whether I want the BitHub reward or not by omitting or adding the word FREEBIE in the commit message of my first commit

---

This simply adds 3 weeks to the list for disappearing messages, making the list feel more complete and allowing to have most conversations with this default setting (1 week is too short).

PR on other clients Desktop and iOS
WhisperSystems/Signal-Desktop#1062
WhisperSystems/SignalServiceKit#115

[Dyras]

Wouldn't 1 month be better? Then the options are 1 day, 1 week and 1 month.

[narzb]

@Dyras
I wanted to write 1 month at first, but because a week is a more accurate unit than a month, I preferred to use a week unit.

My interest is to push back the maximum limit which is one week that I find too short. Whether it's a 3-week period or a one-month period is not important to me. What do you think ?

[motatuc]

I would prefer it like this: 1 day, 7 days, 14 days, 30 days. This would give a consistent wording.

[mueller-ma]

I would prefer just add 4 weeks

[moxie0]

Thanks but I think we're going to stick with our current settings for now

[rbertoche]

If I'm anyone to ask, could you please reconsider it, moxie0? One day, one week period is a too much coarse, a two days window would be way more functional in my personal experience, at least with people that don't look at their phones that often.
Also 1 week max looks a very limited time window to me. I know adding longer times is in fact a compromise in the probability that messages get deleted before some rogue can get access to it, but it is so much better than never deleting!
In my opinion those time options would mean so many more use cases for the disappearing messages I wonder why didn't you wanted it to be added before