Add disappearing message time of 3 weeks#6197
Conversation
This adds 3 weeks to the selectable times for disappearing messages. 1 week maximum is too short for certain uses.
|
@narzb changes like this must be coordinated with the ohter clients (iOS, Desktop). |
|
@p4nci |
|
Excuse me for being so direct. You opened 3 PRs which added 11 lines of code in total. None of the PRs has the word "FREEBIE" in it. I feel a bit bad about giving away 240$ of donations for this quite trivial changes, while there are people who write hundreds of lines for free... Howsoever, moxie has to decide if he wants to merge this. |
|
@ByteHamster I haven't had a chance to look at this PR yet, but I don't think anyone should feel at all bad about collecting bithub rewards for their PRs, even for small ones. It's there to encourage PRs, and some of the best PRs we get are small ones! |
|
@ByteHamster These are my first PR on this project, and I forgot to add the word FREEBIE. I don't care about rewards, so I will redo my PR. |
|
I think the Bithub reward is still such a novel concept that many contributors take it accidentally the first time. Also the description in the checklist is pretty thick, almost legalese. And as people rarely read any kind of licences, disclaimers or other such documents I think the checklist overall suffers the same kind of treatment and the items get marked as complete without actually reading them properly. Especially when you get the checklist after the fact that you have already committed code and opened a PR. Some moons ago I thought that adding a little trap to the list such as "I assure you that I haven't read any of these and I'm just blindly checking these off " would help but it probably wouldn't. |
|
I fixed the // FREEBIE in new PR WhisperSystems/Signal-Android#6219 |
4 participants
This adds 3 weeks to the selectable times for disappearing messages.
1 week maximum is too short for certain uses.
I have read how to contribute to this project
I have signed the Contributor License Agreement
I am following the Code Style Guidelines
I have tested my contribution on these devices:
Fixes #1234syntaxFREEBIEin the commit message of my first commitThis simply adds 3 weeks to the list for disappearing messages, making the list feel more complete and allowing to have most conversations with this default setting (1 week is too short).