[Vite] Migrate clustering-map plugin to ESM #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 13, 2025 15:54
✅ Deploy Preview for sigma-org-chart canceled.
|
ashnaarya
changed the title
Pearce-Ropion
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves SIG-41705
The Vite CJS Node API is deprecated in Vite 6. Converting this to a module so this plugin actually loads. Keeping lint on cjs for now to keep consistent with actions-sample-plugin.
The tests still do not work (CRA comes with Jest as its default test runner, Vite does not). Basically Vite favors ESM, but Jest is still in commonJS world....so we need to migrate to vitest to support unit testing (which is made to be compatible with Jest).