Node fetch #113
Open
Node fetch #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Node v18, FormData is natively supported, no need for library.
Since v18, Node has had a native support for cljs-ajax. In addition, the native fetch seems to be able to handle binaries and streaming, which we need for downloading the asset zip The client implementation of do-* functions contain a bit of duplication which could be removed, but I didn't want to do it yet since the asset zip download may change things a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use native FormData and Node's Fetch instead of
cljs-ajax.Since Node version 18, FormData has been natively supported. Also, Node 18 introduced Fetch which we can use to go HTTP instead of
cljs-ajaxlibrary. In addition,cljs-ajaxdidn't see to have good support for binaries, which is needed for asset pulling with CLI.Due to this PR, we now require Node version 18 or later. Node 18 was released Apr 19, 2022.