Improvements to asset pulling (internal) #115
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If response parsing fails, show the original text
rap1ds
force-pushed
the
pull-asset-zip
branch
3 times, most recently
from
4125c05 to
0660c2e
Compare
Delete the temp file. If it fails, ignore the error. It's anyway just a temp file and will likely get clean up by OS at some point.
rap1ds
force-pushed
the
pull-asset-zip
branch
from
d0c4b3a to
11cad9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #113
Improves asset pulling (Sharetribe internal, not yet released)
Pulls the assets in a zip file and unzips them.