Default db:generate to --pglite#28
Open
Begarudev wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the pgstrap init scaffold so new projects can run bun run db:generate without requiring a running Postgres instance by defaulting generation to PGlite, aligning with Issue #2.
Changes:
- Change the scaffolded
db:generatescript topgstrap generate --pglite. - Update the init test assertion to match the new scaffolded script.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/init.ts |
Updates the generated package.json db:generate script to include --pglite by default. |
tests/init.test.ts |
Updates the test expectation to assert the new db:generate script value. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2.
pgstrap initnow scaffoldsdb:generatewith--pgliteso a freshly bootstrapped project can runbun run db:generatewithout needing a Postgres instance in the background. The flag already exists (added in #1 / #7) — this just flips the default in the init template.Diff
src/init.ts: scaffolded script now readspgstrap generate --pglitetests/init.test.ts: corresponding assertion updatedAnyone who already initialized can opt out per project by editing their own
package.jsonscript back topgstrap generate.bun test/bun run build/bun run format:checkall green locally.@algora-pbc /claim #2