Skip to content

fixed all warnings #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
exit-failure wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed all warnings #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions hingebox_code.scad
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,10 +479,12 @@ module bs_shape( d, btn_d, btn_h, stalk_d, ra=0, f=$fn) {
rotate([0,0,ra])
translate([stend-bdr,d.y/2,wt]) cylinder( d=btn_d, h=btn_h, $fn=f, center=true );
}
hull() { // stalk
translate([bdr,d.y/2,d.z/2]) cylinder( d=stalk_d, h=stht, $fn=f, center=true );
rotate([0,0,ra])
translate([stend-bdr,d.y/2,d.z/2]) cylinder( d=stalk_d, h=stht, $fn=f, center=true );
if(stalk_d != 0) {
hull() { // stalk
translate([bdr,d.y/2,d.z/2]) cylinder( d=stalk_d, h=stht, $fn=f, center=true );
rotate([0,0,ra])
translate([stend-bdr,d.y/2,d.z/2]) cylinder( d=stalk_d, h=stht, $fn=f, center=true );
}
}
} //bs_shape

Expand Down Expand Up @@ -563,10 +565,10 @@ module base_box( d, top_inset=false, f=corner_fn ) {
b=corner_radius;
tb= top_inset ? top_inset : b;
hull() {
translate( [b,b,0] ) cylinder( r=b, r2=tb, h=d.z, $fn=f );
translate( [b,d.y-b,0] ) cylinder( r=b, r2=tb,h=d.z, $fn=f );
translate( [d.x-b,b,0] ) cylinder( r=b, r2=tb,h=d.z, $fn=f );
translate( [d.x-b,d.y-b,0] ) cylinder( r=b, r2=tb,h=d.z, $fn=f );
translate( [b,b,0] ) cylinder( r1=b, r2=tb, h=d.z, $fn=f );
translate( [b,d.y-b,0] ) cylinder( r1=b, r2=tb,h=d.z, $fn=f );
translate( [d.x-b,b,0] ) cylinder( r1=b, r2=tb,h=d.z, $fn=f );
translate( [d.x-b,d.y-b,0] ) cylinder( r1=b, r2=tb,h=d.z, $fn=f );
}
}

Expand Down Expand Up @@ -788,7 +790,7 @@ module hingedbox_half( bd, topflag=false ) {
// hinge pin hole
translate( [0,0,0-CS]) cylinder( d=hinge_id, h=cl+CS2, $fn=ifn);
// nut holes
if (topflag) {
if (topflag && hnut_d != 0) {
if (ntf >0) {translate( [0,0,0-CS] ) cylinder( d=hnut_d, h=hnut_t+CS2, $fn=6 ); }
if (ntf <0) {translate( [0,0,cl-hnut_t] ) cylinder( d=hnut_d, h=hnut_t+CS2, $fn=6 ); }
}
Expand Down