Skip to content

fixed all warnings#2

Open
exit-failure wants to merge 1 commit intosbambach:masterfrom
exit-failure:master
Open

fixed all warnings#2
exit-failure wants to merge 1 commit intosbambach:masterfrom
exit-failure:master

Conversation

@exit-failure
Copy link

Added checks to fix all warnings when the radius of cylinder would be zero. Also fixed warnings where the radius parameters of cylinders were ambiguous.

@CameronBrooks11
Copy link

Similar here, I was getting:
WARNING: Cylinder parameters ambiguous in file ../hingebox_code.scad, line 566
WARNING: Cylinder parameters ambiguous in file ../hingebox_code.scad, line 567
WARNING: Cylinder parameters ambiguous in file ../hingebox_code.scad, line 568
WARNING: Cylinder parameters ambiguous in file ../hingebox_code.scad, line 569

So I fixed lines 562-571 in hingedbox_code.scad:
module base_box(d, top_inset=false, f=corner_fn) {
b = corner_radius;
tb = top_inset ? top_inset : b;
hull() {
translate([b, b, 0]) cylinder(h=d.z, r1=b, r2=tb, $fn=f);
translate([b, d.y-b, 0]) cylinder(h=d.z, r1=b, r2=tb, $fn=f);
translate([d.x-b, b, 0]) cylinder(h=d.z, r1=b, r2=tb, $fn=f);
translate([d.x-b, d.y-b, 0]) cylinder(h=d.z, r1=b, r2=tb, $fn=f);
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants