Skip to content

Conversation

@ruidazeng
Copy link
Collaborator

For both pylint and python application

@ruidazeng ruidazeng requested a review from samdevo December 29, 2024 21:36
@ruidazeng ruidazeng mentioned this pull request Dec 29, 2024
@ruidazeng
Copy link
Collaborator Author

The test failing now is fine, since we haven’t updated main to fit the test requirements yet.

But the tests are at least running as desired.

Copy link
Owner

@samdevo samdevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the lint is failing - maybe took a look? But nice! This is cool

@ruidazeng ruidazeng merged commit 66df978 into main Jan 13, 2025
0 of 4 checks passed
@ruidazeng ruidazeng deleted the workflows branch January 13, 2025 10:43
@ruidazeng
Copy link
Collaborator Author

It looks like the lint is failing - maybe took a look? But nice! This is cool

I will fix it with another pull request, since this PR only adds the tests (incl. linter)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants