Integrated pytest #11
Conversation
|
I don't have too much experience with continuous integration (CI) workflow, but I think we could create a python-app.yml in actions for Python applications. |
|
Never mind, I figured it out. #12 |
|
Need to pass some checks: |
|
Could you approve #12 first? The checks are not passing so I have to refactor my codes a bit more. |
|
@samdevo Continuous integration completed, all code should work with linter and pytest |
trader/arbitrage.py
Outdated
| pool_prices.append((pool.rpc_data, price)) | ||
| print(f"Processed pool {pool.rpc_data} with price {price}") | ||
| except ValueError: | ||
| print(f"Invalid pool_price '{pool.pool_price}' in pool {pool.rpc_data}; skipping.") |
There was a problem hiding this comment.
Where would the ValueError come from?
There was a problem hiding this comment.
pytest files should start with test_* or end with *_test I believe
trader/arbitrage_tests.py
Outdated
|
|
||
| # Safely handle result | ||
| if not isinstance(result, (tuple, list)) or len(result) != 5: | ||
| pytest.fail("Invalid result format: expected 5-element sequence") |
|
And @ruidazeng re your question abt workflows. I think the codebase is too small right now to need workflows for testing. Maybe in the future. But if you want to add and think it's worthwhile fell free! |
Co-authored-by: Sam Devorsetz <samdevorsetz@gmail.com>
merged with passed tests! |
Can we set up a GitHub workflow for this too?