Refactor: optimize cargo clean and improve test reliability#230
Merged
hxuhack merged 3 commits intosafer-rust:mainfrom Mar 3, 2026
Merged
Refactor: optimize cargo clean and improve test reliability#230hxuhack merged 3 commits intosafer-rust:mainfrom
hxuhack merged 3 commits intosafer-rust:mainfrom
Conversation
Adds file-based locking to prevent parallel test execution conflicts that could cause race conditions when multiple tests run simultaneously on the same project directories. This race conditions problem have already caused several test failures in github CI. Optimizes cargo clean to use --workspace flag, avoiding unnecessary removal of dependency artifacts which are time-consuming to rebuild. Runs clean both before and after cargo check to prevent output pollution. Refactors test assertions to use helper functions with clearer error reporting that shows both the expected pattern and full output when assertions fail. Adds debug logging to distinguish between rapx analysis runs and standard rustc compilations for better troubleshooting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Fix test flakes. Adds file-based locking to prevent parallel test execution conflicts that could cause race conditions when multiple tests run simultaneously on the same project directories. This race conditions problem have already caused several test flakes in github CI.
Avoid rebuilding third-party dependencies. Optimizes cargo clean to use --workspace flag, avoiding unnecessary removal of dependency artifacts which are time-consuming to rebuild. Runs clean both before and after cargo check to prevent output pollution.
Better test messages for troubleshooting. Refactors test assertions to use helper functions with clearer error reporting that shows both the expected pattern and full output when assertions fail.
Other: Adds debug logging to distinguish between rapx analysis runs and standard rustc compilations for better troubleshooting.