Refactor: optimize cargo clean and improve test reliability (#230)

* Improves test reliability and cargo clean behavior

Adds file-based locking to prevent parallel test execution conflicts that could cause race conditions when multiple tests run simultaneously on the same project directories. This race conditions problem have already caused several test failures in github CI.

Optimizes cargo clean to use --workspace flag, avoiding unnecessary removal of dependency artifacts which are time-consuming to rebuild. Runs clean both before and after cargo check to prevent output pollution.

Refactors test assertions to use helper functions with clearer error reporting that shows both the expected pattern and full output when assertions fail.

Adds debug logging to distinguish between rapx analysis runs and standard rustc compilations for better troubleshooting.

* fix copilot review advise

* fix

Author: WIZeaz

.gitignore

@@ -6,3 +6,4 @@ UPG/
 tests/**/Cargo.lock
 **/*.dot
 **/*.png
+.rapx-test.lock

rapx/Cargo.lock

@@ -47,10 +47,11 @@ itertools = "0.14.0"
 safety-parser = "0.4.1"
 syn = { version = "2", features = ["extra-traits", "full"] }
 rust_intervals = "0.3.0"
-clap = { version = "4.5.60"}
+clap = { version = "4.5.60" }
 clap-cargo = "0.18.3"
 shlex = "1.3.0"
 color-print = "0.3.7"
+fs4 = "0.13.1"
 [features]
 backtraces = ["snafu/backtraces", "snafu/backtraces-impl-backtrace-crate"]
 

rapx/Cargo.toml

@@ -68,12 +68,21 @@ fn cargo_check(dir: &Utf8Path) {
     } else if !child.wait().unwrap().success() {
         rap_error_and_exit("Finished with non-zero exit code.");
     }
+
+    // Run `cargo clean` again to avoid polluting
+    // the output of `cargo check`
+    cargo_clean(dir, args::rap_clean());
 }
 
 fn cargo_clean(dir: &Utf8Path, really: bool) {
     if really {
         rap_trace!("cargo clean in package folder {dir}");
-        if let Err(err) = Command::new("cargo").arg("clean").current_dir(dir).output() {
+        if let Err(err) = Command::new("cargo")
+            .arg("clean")
+            .arg("--workspace") // use --workspace to clean all members of the workspace, which may be more thorough but also more time-consuming to rebuild
+            .current_dir(dir)
+            .output()
+        {
             rap_error_and_exit(format!("`cargo clean` exits unexpectedly:\n{err}"));
         }
     }

rapx/src/bin/cargo-rapx/cargo_check.rs

@@ -27,15 +27,18 @@ fn phase_rustc_wrapper() {
     rap_trace!("Launch cargo-rapx again triggered by cargo check.");
 
     let is_primary = env::var("CARGO_PRIMARY_PACKAGE").is_ok();
+    let package_name = env::var("CARGO_PKG_NAME").unwrap_or_default();
 
     // check `CARGO_PRIMARY_PACKAGE` to make sure we only run
     // rapx for the local crate, but not dependencies.
     // rapx only checks local crates
     if is_primary {
+        rap_debug!("run rapx for package {}", package_name);
         run_rap();
         return;
     }
 
+    rap_debug!("run rustc for package {}", package_name);
     // for dependencies and some special crate types, run rustc as usual
     run_rustc();
 }