ci: skip databricks tests on fork PRs, and update cross-compat tests for latest pins-R#355
Merged
isabelizimm merged 3 commits intorstudio:mainfrom Mar 13, 2026
Merged
Conversation
nealrichardson
commented
Mar 13, 2026
| run: | | ||
| # TODO: better way to disable all cloud backend tests? | ||
| pytest pins -m 'not fs_rsc and not fs_s3 and not fs_gcs and not fs_abfs and not skip_on_github' | ||
| # Skip all tests requiring credentials, which aren't available on fork PRs. |
Collaborator
Author
There was a problem hiding this comment.
I did a little Claude-research on this and didn't see a better way obviously, not one that wouldn't just be moving this bookkeeping somewhere else. So I opted for adding more explicit reminder comments.
nealrichardson
changed the title
nealrichardson
commented
Mar 13, 2026
| args <- commandArgs(trailingOnly = TRUE) | ||
|
|
||
| board <- board_folder(args[1]) | ||
| board %>% pin_write(mtcars, "mtcars", type="csv") |
Collaborator
Author
There was a problem hiding this comment.
This was necessary because of rstudio/pins-r@a6de973, the latest version of pins doesn't include magrittr
isabelizimm
approved these changes
Mar 13, 2026
Collaborator
isabelizimm
left a comment
isabelizimm
left a comment
There was a problem hiding this comment.
Nice! Thank you for this maintenance!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I stumbled across #353 and saw that CI failed because it was a fork. This should fix it (and being from a fork, should confirm that). Then we can rebase that PR and it should be good.