End-to-end polish: product boundary enforcement, full Overview dashboard, connector security#4
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/rpwalsh/DispatchLayer/sessions/4ede8d26-2f96-4ec1-8b20-1b6ddcfb875f Co-authored-by: rpwalsh <10300352+rpwalsh@users.noreply.github.com>
… dark theme prep Agent-Logs-Url: https://github.com/rpwalsh/DispatchLayer/sessions/4ede8d26-2f96-4ec1-8b20-1b6ddcfb875f Co-authored-by: rpwalsh <10300352+rpwalsh@users.noreply.github.com>
…tests, make verify passes Agent-Logs-Url: https://github.com/rpwalsh/DispatchLayer/sessions/cf4f7144-8fc6-4a0f-89dd-659d08c6dfec Co-authored-by: rpwalsh <10300352+rpwalsh@users.noreply.github.com>
… code review Agent-Logs-Url: https://github.com/rpwalsh/DispatchLayer/sessions/cf4f7144-8fc6-4a0f-89dd-659d08c6dfec Co-authored-by: rpwalsh <10300352+rpwalsh@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
rpwalsh
May 6, 2026 03:43
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instrumentation console was violating its own stated product boundary — prose language (
recommendation,finding,insight,narrative,action item) appeared throughout Python packages, TSX components, and docstrings. Separately, the Overview page was minimal and the connector route exposed stack traces to clients.Product boundary enforcement
packages/signals/engine.py— gutted and replaced withThresholdCrossingEngine;Recommendation,generate_recommendations,RecommendationType,AnomalyFindingentirely removedpackages/signals/ranking.py— rewritten asrank_by_severity(events)signal_event.py,evaluator.py,telemetry.py,predictive/README.md— docstrings purged of all forbidden termsRecommendationTable.tsx— deletedEventStream.tsx— comment fixedMakefile—lint-languagetarget now excludesREADME.md(meta-reference) andpackages/recommendations/directory; was producing false positivesOverview dashboard (full rebuild)
Replaced single-column placeholder with a true 3-column instrumentation console:
NavBar redesigned as dual-row: live UTC clock, Grid Scope, Market, Interval, alert counts, user — all in the status strip above the tab bar.
All data served from new
lib/overview.ts— deterministic seeded LCG, noMath.random().Security
connectors.pywas returningstr(e)directly in API responses across all 5 connector error branches — full exception messages (including paths, config values) visible to any client. Replaced withtype(e).__name__in the response body; full trace logged server-side vialogger.warning().Other
GenerationForecast.tsx,AssetHealth.tsx— chart axis/tick colors corrected for dark themepackages/adapters/open_meteo/tests/test_contract.py—async deftest without async plugin fixed to syncdocs/proofs-method.md— holdout validation method documented (train 2000–2024, blind forecast 2025, overlay actuals post-hoc)