Skip to content

Fix Python linking on OSX #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tobias-Fischer wants to merge 2 commits into
base: rolling
Choose a base branch
from
Open

Fix Python linking on OSX #806

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab157fe
Fix Python linking on osx
Tobias-Fischer Jul 20, 2021
fd29665
Fix new style link
Tobias-Fischer Jul 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion rclpy/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,17 @@ add_library(rclpy_common SHARED
)
target_link_libraries(rclpy_common PUBLIC
pybind11::pybind11
${PYTHON_LIBRARIES}
rcl::rcl
rmw::rmw
)

if(NOT APPLE)
target_link_libraries(rclpy_common PUBLIC ${PYTHON_LIBRARIES})
else()
set_target_properties(rclpy_common PROPERTIES
LINK_FLAGS "-undefined dynamic_lookup")
endif()

target_include_directories(rclpy_common PUBLIC
src/rclpy_common/include
)
Expand Down