Feature: expose event callback setter in subscription, service, client and timer (backport #1496)#1502
Open
mergify[bot] wants to merge 1 commit intokiltedfrom
Open
Feature: expose event callback setter in subscription, service, client and timer (backport #1496)#1502mergify[bot] wants to merge 1 commit intokiltedfrom
mergify[bot] wants to merge 1 commit intokiltedfrom
Conversation
…t and timer (#1496) * Added set_on_new_response_callback Signed-off-by: Nadav Elkabets <elnadav12@gmail.com> * Added set_on_new_request_callback Signed-off-by: Nadav Elkabets <elnadav12@gmail.com> * Added set_on_new_message_callback Signed-off-by: Nadav Elkabets <elnadav12@gmail.com> * Added set_on_reset_callback Signed-off-by: Nadav Elkabets <elnadav12@gmail.com> * Added type hints to pyi Signed-off-by: Nadav Elkabets <elnadav12@gmail.com> * Added test for subscription Signed-off-by: Nadav Elkabets <elnadav12@gmail.com> * Added test for timer Signed-off-by: Nadav Elkabets <elnadav12@gmail.com> * Added test for client Signed-off-by: Nadav Elkabets <elnadav12@gmail.com> * Added test for service Signed-off-by: Nadav Elkabets <elnadav12@gmail.com> * Fixed lint Signed-off-by: Nadav Elkabets <elnadav12@gmail.com> * Avoid throwing into c code Signed-off-by: Nadav Elkabets <elnadav12@gmail.com> * Print newline after logging exception Co-authored-by: William Woodall <wjwwood@gmail.com> Signed-off-by: Nadav Elkabets <32939935+nadavelkabets@users.noreply.github.com> * Improve logging and cleanup Signed-off-by: Nadav Elkabets <elnadav12@gmail.com> --------- Signed-off-by: Nadav Elkabets <elnadav12@gmail.com> Signed-off-by: Nadav Elkabets <32939935+nadavelkabets@users.noreply.github.com> Co-authored-by: William Woodall <wjwwood@gmail.com> (cherry picked from commit c834c24) # Conflicts: # rclpy/test/test_service.py # rclpy/test/test_subscription.py
Contributor
Author
|
Cherry-pick of c834c24 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
@nadavelkabets can you resolve the conflicts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1399.
This is an automatic backport of pull request Feature: expose event callback setter in subscription, service, client and timer #1496 done by Mergify.