Revert "Add new rcutils_raw_steady_time_now method changes (#1248)"#1267
Revert "Add new rcutils_raw_steady_time_now method changes (#1248)"#1267
Conversation
This reverts commit c80701e. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
|
@ahcorde i think we need to revert this, can you review the description and approve? |
|
Pulls: #1267 |
|
Note after this revert commit is merged, we need to create revert this reverted commit and link it to the client's PRs. |
| /// Use a steady clock time | ||
| RCL_STEADY_TIME, | ||
| /// Use a monotonic slew-free steady clock time | ||
| RCL_RAW_STEADY_TIME |
There was a problem hiding this comment.
This type is not checked in the client rclcpp/rclpy layer just yet, that generates the CI warnings.
|
@ahcorde & @fujitatomoya, I think some tests are still using the reverted API change. |
|
@SuperJappie08 can you point out where it is in the source code link? |
|
@fujitatomoya, sorry I looked wrong. |
This reverts commit c80701e.
Description
This reverts #1248, which generates the following CI warnings.
https://ci.ros2.org/job/ci_linux-aarch64/19464/
Is this user-facing behavior change?
Did you use Generative AI?
Additional Information
see discussion ros2/rclcpp#2910, on the rclcpp layer, this will generate the inconsistent behavior between
nowandsleep_untilmethods. until it can be resolved, i think we do not need to merge this rcl layer either.